Source/core/svg/SVGAElement.h - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAElement.h

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAElement.h

diff --git a/Source/core/svg/SVGAElement.h b/Source/core/svg/SVGAElement.h

index 6598d6b79dda1b950536ee187082a896c2d97885..a938f78741b6aef0ad4a340c5d47a55d38a16614 100644

--- a/Source/core/svg/SVGAElement.h

+++ b/Source/core/svg/SVGAElement.h

@@ -41,7 +41,7 @@ private:

virtual bool isValid() const { return SVGTests::isValid(); }

virtual String title() const;

- virtual String target() const { return svgTargetCurrentValue(); }

+ virtual AtomicString target() const OVERRIDE { return AtomicString(svgTargetCurrentValue()); }

bool isSupportedAttribute(const QualifiedName&);

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;

« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »