Source/web/FrameLoaderClientImpl.cpp - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index ea1ce2432f9fad4e869b3aff770812fb8218f4a1..5e9cc5f98a7957c30943fad376ed59bb5be08855 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -577,12 +577,12 @@ void FrameLoaderClientImpl::transitionToCommittedForNewPage()

PassRefPtr<Frame> FrameLoaderClientImpl::createFrame(

const KURL& url,

- const String& name,

+ const AtomicString& name,

const String& referrer,

HTMLFrameOwnerElement* ownerElement)

{

FrameLoadRequest frameRequest(m_webFrame->frame()->document(),

- ResourceRequest(url, referrer), name);

+ ResourceRequest(url, AtomicString(referrer)), name);

return m_webFrame->createChildFrame(frameRequest, ownerElement);

}

« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »