Source/web/WebViewImpl.cpp - Issue 122993002: Make calls to AtomicString(const String&) explicit in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 122993002: Make calls to AtomicString(const String&) explicit in web/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use AtomicString type for frameName and target Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 90b794ad98a9b90f59d1e412771e5147fbacecaa..50420131df9ce8596f2ccacae7417f05548b8c26 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -2468,7 +2468,7 @@ void WebViewImpl::setPageEncoding(const WebString& encodingName)

// Only change override encoding, don't change default encoding.

// Note that the new encoding must be 0 if it isn't supposed to be set.

- String newEncodingName;

+ AtomicString newEncodingName;

if (!encodingName.isEmpty())

newEncodingName = encodingName;

m_page->mainFrame()->loader().reload(NormalReload, KURL(), newEncodingName);

« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »