Build all targets on Android's GN bots

Build all targets on Android's GN bots

BUG=507294

[agrieve, 2015-07-09 15:39:28]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, tfarina@chromium.org

[Dirk Pranke, 2015-07-09 15:45:17]

https://codereview.chromium.org/1229723004/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1229723004/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:4: "all"
When we ran w/ "all" before, we had problems (at least on debug, I think) that
this ended up being 100GB+ per build. 

Can you confirm that this is no longer the case?

Also, we don't actually build 'all' on any other GN trybot, only on the linux
clobber bot on the main waterfall; instead, we build just the set of test
targets we'd like to be running. Perhaps it makes sense to do the same thing
here?

[Dirk Pranke, 2015-07-09 15:46:11]

Oh yeah, also, 'all' will mess up the 'analyze' step and build everything on
every patch, which we don't want.

So at least the trybot needs to have a specific list of targets for now.

[agrieve, 2015-07-09 16:02:25]

On 2015/07/09 15:46:11, Dirk Pranke wrote:
> Oh yeah, also, 'all' will mess up the 'analyze' step and build everything on
> every patch, which we don't want.
> 
> So at least the trybot needs to have a specific list of targets for now.

I'm sure your right about this being a bad idea.

Android doesn't seem to have a clobber bot. Do you think it should have one
(what's a clobber bot)?

I also wonder if it makes sense to run "ninja -n all" just to check for ninja
errors with the all target (e.g. a non-existent input as happened in
https://crrev.com/6db810b0998dae50baf254c0e1a6136b77739366). wdyt?

[Dirk Pranke, 2015-07-09 16:10:40]

On 2015/07/09 16:02:25, agrieve wrote:
> On 2015/07/09 15:46:11, Dirk Pranke wrote:
> > Oh yeah, also, 'all' will mess up the 'analyze' step and build everything on
> > every patch, which we don't want.
> > 
> > So at least the trybot needs to have a specific list of targets for now.
> 
> I'm sure your right about this being a bad idea.
> 
> Android doesn't seem to have a clobber bot. Do you think it should have one
> (what's a clobber bot)?

A clobber bot is one that does a clean build from scratch every time.

I wouldn't set one up until we thought we needed it, i.e., we were hitting bugs
too often.

> 
> I also wonder if it makes sense to run "ninja -n all" just to check for ninja
> errors with the all target (e.g. a non-existent input as happened in
> https://crrev.com/6db810b0998dae50baf254c0e1a6136b77739366). wdyt?

That seems like an interesting idea.