Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1229073003: Move Android version stamping from an exec_script -> build rule (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn14
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Android version stamping from an exec_script -> build rule BUG= Committed: https://crrev.com/5f3dec8ead48312eea0b4a27329c4faf231333c7 Cr-Commit-Position: refs/heads/master@{#338292}

Patch Set 1 #

Patch Set 2 : fix default argument for native lib version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M build/config/android/rules.gni View 1 2 chunks +11 lines, -4 lines 0 comments Download
M build/util/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +8 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
agrieve
5 years, 5 months ago (2015-07-09 18:49:49 UTC) #1
agrieve
yfriedman@chromium.org: Please review changes in cjhopman@chromium.org: Please review changes in
5 years, 5 months ago (2015-07-09 19:37:37 UTC) #3
cjhopman
lgtm
5 years, 5 months ago (2015-07-10 02:30:18 UTC) #4
Yaron
lgtm
5 years, 5 months ago (2015-07-10 12:17:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229073003/1
5 years, 5 months ago (2015-07-10 13:58:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/90356)
5 years, 5 months ago (2015-07-10 14:11:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229073003/20001
5 years, 5 months ago (2015-07-10 14:29:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 15:18:49 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 15:19:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f3dec8ead48312eea0b4a27329c4faf231333c7
Cr-Commit-Position: refs/heads/master@{#338292}

Powered by Google App Engine
This is Rietveld 408576698