Enable "gn check" on android GN bots

Enable "gn check" on android GN bot.

But not try bot since it is not configured to run tests locally (not on a device)

BUG=376000
R=dpranke@chromium.org,tfarina@chromium.org

Committed: https://crrev.com/00087593106713568ab4e3caf6bab3c39851d8f4
Cr-Commit-Position: refs/heads/master@{#338226}

[agrieve, 2015-07-09 15:38:59]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-07-09 15:42:35]

lgtm

[agrieve, 2015-07-09 18:54:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-07-09 18:55:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228123002/1

[tfarina, 2015-07-09 18:56:26]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-07-09 18:56:27]

lgtm2 (provided that Dirk is happy with this), thanks.

https://codereview.chromium.org/1228123002/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1228123002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:61: "script": "gn_check.py"
only in release? Do we want to do this in the debug config too? (I think this is
more a question to Dirk though).

[commit-bot: I haz the power, 2015-07-09 19:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 19:32:56]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[agrieve, 2015-07-09 19:51:30]

On 2015/07/09 19:32:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

Another question for Dirk:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...

Looking for guidance on how to fix this. Seems the recipe is trying to start up
adb logcat even though the script isn't meant to be used in the context of
running something on device.

[Dirk Pranke, 2015-07-10 01:11:10]

On 2015/07/09 18:56:27, tfarina wrote:
> lgtm2 (provided that Dirk is happy with this), thanks.
> 
>
https://codereview.chromium.org/1228123002/diff/1/testing/buildbot/chromium.l...
> File testing/buildbot/chromium.linux.json (right):
> 
>
https://codereview.chromium.org/1228123002/diff/1/testing/buildbot/chromium.l...
> testing/buildbot/chromium.linux.json:61: "script": "gn_check.py"
> only in release? Do we want to do this in the debug config too? (I think this
is
> more a question to Dirk though).

I wouldn't worry about covering both debug and release too much. Maybe at some
point, but no need to do it now.

[Dirk Pranke, 2015-07-10 01:14:11]

On 2015/07/09 19:51:30, agrieve wrote:
> On 2015/07/09 19:32:56, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
> 
> Another question for Dirk:
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> 
> Looking for guidance on how to fix this. Seems the recipe is trying to start
up
> adb logcat even though the script isn't meant to be used in the context of
> running something on device.

Oh, whoops. The 'scripts' block can't work on the
android_chromium_gn_compile_rel bot, because
the recipe doesn't have any way to tell that 'gn check' just runs on the host
and doesn't need
any devices. So, it assumes that if there are any tests on an android bot, we
need devices,
and tries to set up some. Which, one those bots, which have no devices, won't
work :).

So for now let's just run 'gn check' on the waterfall bot and hope we don't get
too many inconsistencies.
If we do, we can fix this differently then.

[agrieve, 2015-07-10 01:38:11]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-07-10 01:38:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1228123002/#ps20001
(title: "only run on waterfall (not trybot)")

[commit-bot: I haz the power, 2015-07-10 01:38:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228123002/20001

[commit-bot: I haz the power, 2015-07-10 02:48:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-10 02:49:24]

Patchset 2 (id:??) landed as
https://crrev.com/00087593106713568ab4e3caf6bab3c39851d8f4
Cr-Commit-Position: refs/heads/master@{#338226}