Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: record reloc info for debug break slot immediate before the slot. If we do it too early, we might get a constant pool between the reloc info and the actual slot. R=ulan@chromium.org Committed: https://crrev.com/0a19e44925301b9c0a554bbec5e3fb5a6cd09efa Cr-Commit-Position: refs/heads/master@{#29568}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M src/arm/debug-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/arm64/debug-arm64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/debug.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/mips/debug-mips.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/mips64/debug-mips64.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229673005/1
5 years, 5 months ago (2015-07-10 11:29:25 UTC) #2
ulan
lgtm
5 years, 5 months ago (2015-07-10 11:30:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/2596)
5 years, 5 months ago (2015-07-10 11:41:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229673005/20001
5 years, 5 months ago (2015-07-10 11:43:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 12:47:22 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 12:47:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a19e44925301b9c0a554bbec5e3fb5a6cd09efa
Cr-Commit-Position: refs/heads/master@{#29568}

Powered by Google App Engine
This is Rietveld 408576698