Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/debug-mips.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips64/debug-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS 9 #if V8_TARGET_ARCH_MIPS
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 122
123 123
124 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 124 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
125 // In places other than IC call sites it is expected that v0 is TOS which 125 // In places other than IC call sites it is expected that v0 is TOS which
126 // is an object - this is not generally the case so this should be used with 126 // is an object - this is not generally the case so this should be used with
127 // care. 127 // care.
128 Generate_DebugBreakCallHelper(masm, v0.bit()); 128 Generate_DebugBreakCallHelper(masm, v0.bit());
129 } 129 }
130 130
131 131
132 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 132 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
133 DebugCodegen::SlotLocation location,
134 int call_argc) {
133 // Generate enough nop's to make space for a call instruction. Avoid emitting 135 // Generate enough nop's to make space for a call instruction. Avoid emitting
134 // the trampoline pool in the debug break slot code. 136 // the trampoline pool in the debug break slot code.
135 Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm); 137 Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm);
136 Label check_codesize; 138 Label check_codesize;
137 __ bind(&check_codesize); 139 __ bind(&check_codesize);
140 RecordRelocInfo(masm, location, call_argc);
138 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) { 141 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
139 __ nop(MacroAssembler::DEBUG_BREAK_NOP); 142 __ nop(MacroAssembler::DEBUG_BREAK_NOP);
140 } 143 }
141 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions, 144 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions,
142 masm->InstructionsGeneratedSince(&check_codesize)); 145 masm->InstructionsGeneratedSince(&check_codesize));
143 } 146 }
144 147
145 148
146 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 149 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
147 // In the places where a debug break slot is inserted no registers can contain 150 // In the places where a debug break slot is inserted no registers can contain
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 184
182 185
183 const bool LiveEdit::kFrameDropperSupported = true; 186 const bool LiveEdit::kFrameDropperSupported = true;
184 187
185 #undef __ 188 #undef __
186 189
187 } // namespace internal 190 } // namespace internal
188 } // namespace v8 191 } // namespace v8
189 192
190 #endif // V8_TARGET_ARCH_MIPS 193 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips64/debug-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698