Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: src/debug.h

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/debug-arm64.cc ('k') | src/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index d7470d12352e398681763ceadfc4b23b0d1461b4..bde56c2b7cc99b5e052ac8b043cba906cd0d4ba6 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -791,7 +791,14 @@ class SuppressDebug BASE_EMBEDDED {
// Code generator routines.
class DebugCodegen : public AllStatic {
public:
- static void GenerateSlot(MacroAssembler* masm);
+ enum SlotLocation {
+ PLAIN_DEBUG_BREAK,
+ DEBUG_BREAK_AT_CALL,
+ DEBUG_BREAK_AT_CONSTRUCT_CALL
+ };
+
+ static void GenerateSlot(MacroAssembler* masm, SlotLocation location,
+ int call_argc = -1);
static void GenerateReturnDebugBreak(MacroAssembler* masm);
static void GenerateSlotDebugBreak(MacroAssembler* masm);
static void GeneratePlainReturnLiveEdit(MacroAssembler* masm);
@@ -801,6 +808,10 @@ class DebugCodegen : public AllStatic {
// There is no calling conventions here, because it never actually gets
// called, it only gets returned to.
static void GenerateFrameDropperLiveEdit(MacroAssembler* masm);
+
+ private:
+ static void RecordRelocInfo(MacroAssembler* masm, SlotLocation location,
+ int call_argc);
};
« no previous file with comments | « src/arm64/debug-arm64.cc ('k') | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698