Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1229573003: Teach i18nTemplate.process() to handle <link rel=import> and <template> (Closed)

Created:
5 years, 5 months ago by Dan Beam
Modified:
5 years, 5 months ago
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach i18nTemplate.process() to handle <link rel=import> and <template> This is required to support Polymerized web UI until we figure out a more flicker-resistant solution (see: crbug.com/506009) This CL was previously reverted here because it broke OOBE login: https://codereview.chromium.org/1234753002/ BUG=425626, 509087 R=arv@chromium.org,dzhioev@chromium.org TBR=yoshiki@chromium.org Committed: https://crrev.com/b163dffbb26ab34a52a29e2dc8ccd00d0dbac431 Cr-Commit-Position: refs/heads/master@{#337980} Committed: https://crrev.com/3e0fadfeaad12f8ef176d8ed6571f109b9479985 Cr-Commit-Position: refs/heads/master@{#338758}

Patch Set 1 : better doc comment #

Patch Set 2 : fix tests #

Total comments: 2

Patch Set 3 : test fixes #

Patch Set 4 : +cycle detection #

Patch Set 5 : comment fix #

Patch Set 6 : tmp -> temp #

Patch Set 7 : +cycle test #

Total comments: 4

Patch Set 8 : add more tests #

Patch Set 9 : videoplayer test fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -43 lines) Patch
M chrome/browser/resources/bookmark_manager/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/webui/i18n_process_test.html View 1 2 3 4 5 6 7 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M components/chrome_apps/webstore_widget/app/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/externs/compiled_resources.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/closure_compiler/externs/pending_compiler_externs.js View 1 chunk +5 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/video_player/check_elements.js View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/i18n_process.css View 1 2 3 4 1 chunk +10 lines, -2 lines 0 comments Download
M ui/webui/resources/js/compiled_resources.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/webui/resources/js/compiled_resources2.gyp View 1 chunk +10 lines, -2 lines 0 comments Download
M ui/webui/resources/js/i18n_template_no_process.js View 1 2 3 4 5 6 chunks +87 lines, -25 lines 0 comments Download
M ui/webui/resources/js/webui_resource_test.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (17 generated)
Dan Beam
5 years, 5 months ago (2015-07-08 02:18:15 UTC) #5
arv (Not doing code reviews)
LGTM Do you need to update the gn build files too? https://codereview.chromium.org/1229573003/diff/80001/chrome/test/data/webui/i18n_process_test.html File chrome/test/data/webui/i18n_process_test.html (right): ...
5 years, 5 months ago (2015-07-08 22:29:16 UTC) #6
Dan Beam
TBR=yoshiki@ for ui/file_manager and components/chrome_apps/webstore_widget btw, had to switch back to `var` (instead of `let`) ...
5 years, 5 months ago (2015-07-08 23:25:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229573003/140001
5 years, 5 months ago (2015-07-09 01:20:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:140001)
5 years, 5 months ago (2015-07-09 03:33:21 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b163dffbb26ab34a52a29e2dc8ccd00d0dbac431 Cr-Commit-Position: refs/heads/master@{#337980}
5 years, 5 months ago (2015-07-09 03:34:04 UTC) #15
Dan Beam
this was reverted because it broke OOBE login +dzhioev@ for cycle detection logic will test ...
5 years, 5 months ago (2015-07-14 01:30:05 UTC) #17
dzhioev (left Google)
https://codereview.chromium.org/1229573003/diff/220001/chrome/test/data/webui/i18n_process_test.html File chrome/test/data/webui/i18n_process_test.html (right): https://codereview.chromium.org/1229573003/diff/220001/chrome/test/data/webui/i18n_process_test.html#newcode51 chrome/test/data/webui/i18n_process_test.html:51: } I believe we need tests for actual custom ...
5 years, 5 months ago (2015-07-14 02:43:23 UTC) #18
Dan Beam
I can more tests soon, though I'd be happy to do in followup as well. ...
5 years, 5 months ago (2015-07-14 05:31:17 UTC) #19
Dan Beam
https://codereview.chromium.org/1229573003/diff/220001/chrome/test/data/webui/i18n_process_test.html File chrome/test/data/webui/i18n_process_test.html (right): https://codereview.chromium.org/1229573003/diff/220001/chrome/test/data/webui/i18n_process_test.html#newcode51 chrome/test/data/webui/i18n_process_test.html:51: } On 2015/07/14 02:43:22, dzhioev wrote: > I believe ...
5 years, 5 months ago (2015-07-14 16:28:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229573003/240001
5 years, 5 months ago (2015-07-14 17:38:28 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/78181)
5 years, 5 months ago (2015-07-14 19:47:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229573003/240001
5 years, 5 months ago (2015-07-14 19:56:32 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229573003/260001
5 years, 5 months ago (2015-07-14 21:11:40 UTC) #31
commit-bot: I haz the power
Committed patchset #9 (id:260001)
5 years, 5 months ago (2015-07-14 22:30:19 UTC) #32
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 22:31:33 UTC) #33
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/3e0fadfeaad12f8ef176d8ed6571f109b9479985
Cr-Commit-Position: refs/heads/master@{#338758}

Powered by Google App Engine
This is Rietveld 408576698