Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ui/webui/resources/js/compiled_resources2.gyp

Issue 1229573003: Teach i18nTemplate.process() to handle <link rel=import> and <template> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: videoplayer test fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/compiled_resources.gyp ('k') | ui/webui/resources/js/i18n_template_no_process.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/compiled_resources2.gyp
diff --git a/ui/webui/resources/js/compiled_resources2.gyp b/ui/webui/resources/js/compiled_resources2.gyp
index bdd520adea6f382f2a29163e60b83a2fc2489a42..2d0ce6627aedb5d2c80e025e02b8f908356b5232 100644
--- a/ui/webui/resources/js/compiled_resources2.gyp
+++ b/ui/webui/resources/js/compiled_resources2.gyp
@@ -42,12 +42,20 @@
},
{
'target_name': 'i18n_template_no_process',
- 'dependencies': ['load_time_data'],
+ 'dependencies': [
+ 'load_time_data',
+ '<(EXTERNS_GYP):pending_compiler_externs',
+ ],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
{
'target_name': 'i18n_template',
- 'dependencies': ['load_time_data'],
+ 'dependencies': [
+ 'load_time_data',
+ # Ideally, <include> would automatically import externs as well, but
+ # it current doesn't and that sounds hard. Let's just kill <include>.
+ '<(EXTERNS_GYP):pending_compiler_externs',
+ ],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
],
« no previous file with comments | « ui/webui/resources/js/compiled_resources.gyp ('k') | ui/webui/resources/js/i18n_template_no_process.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698