chrome/test/data/webui/i18n_process_test.html - Issue 1229573003: Teach i18nTemplate.process() to handle <link rel=import> and <template>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/webui/i18n_process_test.html

Issue 1229573003: Teach i18nTemplate.process() to handle <link rel=import> and <template> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/compiled_resources.gyp ('k') | chrome/test/data/webui/webui_resource_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title i18n-content="title"></title>

	5 <link rel="import" href="data:text/html,

	6 <link rel=import href="data:text/html,
	arv (Not doing code reviews) 2015/07/08 22:29:16 Can you use ' instead? Can you use ' instead? Dan Beam 2015/07/08 23:25:50 Done. Show quoted text On 2015/07/08 22:29:16, arv wrote: > Can you use ' instead? Done.
	7 <div i18n-content=nested>">">

	8 </head>

	9 <body i18n-values="type:type">

	10 <span i18n-values=".innerHTML:content;.style.display:display"><3</span>

	11 <template>

	12 <template>

	13 <div i18n-content="nested"></div>

	14 </template>

	15 </template>

	16 <script>

	17 function setUpPage() {

	18 loadTimeData.data = {

	19 'content': "doesn't matter; you can't see me!",

	20 'display': 'none',

	21 'title': 'BUY NOW!',

	22 'type': 'ectomorph',

	23 'nested': 'real deep',

	24 };

	25 i18nTemplate.process(document, loadTimeData);

	26 }

	27

	28 function testI18nProcess_Attributes() {

	29 assertNotEqual(0, document.title.length);

	30 assertTrue(document.body.hasAttribute('type'));

	31 assertTrue(document.querySelector('span').textContent.length > 5);

	32 assertEquals('none', document.querySelector('span').style.display);

	33 }

	34

	35 function testI18nProcess_Imports() {

	36 var outerImportDoc = document.querySelector('link').import;

	37 var innerImportDoc = outerImportDoc.querySelector('link').import;

	38 assertNotEqual(0, innerImportDoc.querySelector('div').textContent.length);

	39 }

	40

	41 function testI18nProcess_Templates() {

	42 var outerDocFrag = document.querySelector('template').content;

	43 var innerDocFrag = outerDocFrag.querySelector('template').content;

	44 assertNotEqual(0, innerDocFrag.querySelector('div').textContent.length);

	45 }

	46 </script>

	47 </body>

	48 </html>

OLD	NEW