Add a footer at the bottom of the menu for custom tabs

chrome/android/java/res/layout/powered_by_chrome_footer.xml

Index: chrome/android/java/res/layout/powered_by_chrome_footer.xml
diff --git a/chrome/android/java/res/layout/powered_by_chrome_footer.xml b/chrome/android/java/res/layout/powered_by_chrome_footer.xml
new file mode 100644
index 0000000000000000000000000000000000000000..e8ef6568119f7bcebb8ed20783857392126ec7d2
--- /dev/null
+++ b/chrome/android/java/res/layout/powered_by_chrome_footer.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"

[newt (away), 2015/07/10 18:55:46]

Technically, this height should be powered_by_chrome_footer_height, otherwise,
the layout calculations in AppMenu will be off by 1dp, right?

[Yusuf, 2015/07/10 19:12:19]

Yes, to the technicality. No to the calculations. Since this is a framelayout
the total height ends up being 28dp anyway, right?

For some reason if I change the height here the parent layout ends up overriding
that and squishing things to wrap_content on the textview only. Any suggestions?

[newt (away), 2015/07/10 19:18:38]

That probably happens because you're not passing a parent when you inflate
powered_by_chrome_footer.xml. If you don't pass a parent when inflating a view,
then the view will end with up default layout params instead of the very
carefully chosen layout params that you specified in the layout file.

Regardless, I agree that since this is a FrameLayout, it's fine to make its
height wrap_content. You should probably also add paddingTop="1dp" to the
TextView.

[Yusuf, 2015/07/10 19:23:55]

Ah. I see. OK added the padding to the top.

+    android:background="#f5f5f5" >
+    <View
+        android:layout_width="match_parent"
+        android:layout_height="1dp"
+        android:background="#e0e0e0" />
+    <TextView
+        android:layout_width="match_parent"
+        android:layout_height="@dimen/powered_by_chrome_footer_height"

[newt (away), 2015/07/10 18:55:46]

Then, this can simply be match_parent. You could also add
layout_marginTop="1dp".

+        android:paddingStart="16dp"
+        android:paddingEnd="16dp"
+        android:gravity="start|center_vertical"
+        android:textSize="12sp"
+        android:textColor="#616161"
+        android:text="@string/powered_by_chrome_message"
+        android:singleLine="true" />

[newt (away), 2015/07/10 18:55:46]

maxLines="1" is recommended over singleLine="true" for its simpler and more
performant behavior

http://stackoverflow.com/questions/17124985/why-does-androidsingleline-true-m...

[Yusuf, 2015/07/10 19:12:19]

Done.

+</FrameLayout>