chrome/android/java/res/layout/powered_by_chrome_footer.xml - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Side by Side Diff: chrome/android/java/res/layout/powered_by_chrome_footer.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed first review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="match_parent"

	8 android:layout_height="wrap_content"
	newt (away) 2015/07/10 18:55:46 Technically, this height should be powered_by_chro Technically, this height should be powered_by_chrome_footer_height, otherwise, the layout calculations in AppMenu will be off by 1dp, right? Yusuf 2015/07/10 19:12:19 Yes, to the technicality. No to the calculations. Show quoted text On 2015/07/10 18:55:46, newt wrote: > Technically, this height should be powered_by_chrome_footer_height, otherwise, > the layout calculations in AppMenu will be off by 1dp, right? Yes, to the technicality. No to the calculations. Since this is a framelayout the total height ends up being 28dp anyway, right? For some reason if I change the height here the parent layout ends up overriding that and squishing things to wrap_content on the textview only. Any suggestions? newt (away) 2015/07/10 19:18:38 That probably happens because you're not passing a Show quoted text On 2015/07/10 19:12:19, Yusuf wrote: > On 2015/07/10 18:55:46, newt wrote: > > Technically, this height should be powered_by_chrome_footer_height, otherwise, > > the layout calculations in AppMenu will be off by 1dp, right? > > Yes, to the technicality. No to the calculations. Since this is a framelayout > the total height ends up being 28dp anyway, right? > > For some reason if I change the height here the parent layout ends up overriding > that and squishing things to wrap_content on the textview only. Any suggestions? That probably happens because you're not passing a parent when you inflate powered_by_chrome_footer.xml. If you don't pass a parent when inflating a view, then the view will end with up default layout params instead of the very carefully chosen layout params that you specified in the layout file. Regardless, I agree that since this is a FrameLayout, it's fine to make its height wrap_content. You should probably also add paddingTop="1dp" to the TextView. Yusuf 2015/07/10 19:23:55 Ah. I see. OK added the padding to the top. Show quoted text On 2015/07/10 19:18:38, newt wrote: > On 2015/07/10 19:12:19, Yusuf wrote: > > On 2015/07/10 18:55:46, newt wrote: > > > Technically, this height should be powered_by_chrome_footer_height, > otherwise, > > > the layout calculations in AppMenu will be off by 1dp, right? > > > > Yes, to the technicality. No to the calculations. Since this is a framelayout > > the total height ends up being 28dp anyway, right? > > > > For some reason if I change the height here the parent layout ends up > overriding > > that and squishing things to wrap_content on the textview only. Any > suggestions? > > That probably happens because you're not passing a parent when you inflate > powered_by_chrome_footer.xml. If you don't pass a parent when inflating a view, > then the view will end with up default layout params instead of the very > carefully chosen layout params that you specified in the layout file. > > Regardless, I agree that since this is a FrameLayout, it's fine to make its > height wrap_content. You should probably also add paddingTop="1dp" to the > TextView. Ah. I see. OK added the padding to the top.
	9 android:background="#f5f5f5" >

	10 <View

	11 android:layout_width="match_parent"

	12 android:layout_height="1dp"

	13 android:background="#e0e0e0" />

	14 <TextView

	15 android:layout_width="match_parent"

	16 android:layout_height="@dimen/powered_by_chrome_footer_height"
	newt (away) 2015/07/10 18:55:46 Then, this can simply be match_parent. You could a Then, this can simply be match_parent. You could also add layout_marginTop="1dp".
	17 android:paddingStart="16dp"

	18 android:paddingEnd="16dp"

	19 android:gravity="start\|center_vertical"

	20 android:textSize="12sp"

	21 android:textColor="#616161"

	22 android:text="@string/powered_by_chrome_message"

	23 android:singleLine="true" />
	newt (away) 2015/07/10 18:55:46 maxLines="1" is recommended over singleLine="true" maxLines="1" is recommended over singleLine="true" for its simpler and more performant behavior http://stackoverflow.com/questions/17124985/why-does-androidsingleline-true-m... Yusuf 2015/07/10 19:12:19 Done. Show quoted text On 2015/07/10 18:55:46, newt wrote: > maxLines="1" is recommended over singleLine="true" for its simpler and more > performant behavior > > http://stackoverflow.com/questions/17124985/why-does-androidsingleline-true-m... Done.
	24 </FrameLayout>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('J')