chrome/android/java/res/values/dimens.xml - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed first review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/powered_by_chrome_footer.xml ('K') | « chrome/android/java/res/layout/powered_by_chrome_footer.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 2a96f4553afd9dd392c8ac9642c1b4570e0e8a0b..4de9eea9a15e98d4dbe57e64a1eeb0e40cd216bd 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -286,4 +286,5 @@

+ <dimen name="powered_by_chrome_footer_height">28dp</dimen>

</resources>