Move Android version stamping from an exec_script -> build rule

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/module_args/v8.gni")
 import("//chrome/version.gni")
 import("//testing/test.gni")
 import("//third_party/icu/config.gni")
@@ skipping 353 matching lines @@
 chrome_shell_manifest =
     "$target_gen_dir/chrome_shell_manifest/AndroidManifest.xml"
 
 # GYP: //chrome/chrome_shell.gypi:chrome_shell_manifest
 jinja_template("chrome_shell_manifest") {
   testonly = true
   input = "shell/java/AndroidManifest.xml.jinja2"
   output = chrome_shell_manifest
 }
 
-# TODO(cjhopman): This should actually be done as a build step instead of at gn
-# time.
-_version_py_path = "//build/util/version.py"
-_chrome_version_path = "//chrome/VERSION"
-_version_full = exec_script(_version_py_path,
-                            [
-                              "-f",
-                              rebase_path(_chrome_version_path, root_build_dir),
-                              "-t \"@MAJOR@.@MINOR@.@BUILD@.@PATCH@\"",
-                            ],
-                            "value",
-                            [ _chrome_version_path ])
-
 # GYP: //chrome/chrome_shell.gypi:chrome_shell_apk
 android_apk("chrome_shell_apk") {
   testonly = true
   deps = [
     ":chrome_shell",
     ":chrome_shell_assets",
     ":chrome_shell_java",
     ":chrome_shell_manifest",
     ":chrome_shell_resources",
     "//base:base_java",
   ]
   apk_name = "ChromeShell"
   android_manifest = chrome_shell_manifest
   native_libs = [ "libchrome_shell.so" ]
-  native_lib_version_name = _version_full
+  native_lib_version_rule = "//build/util:chrome_version_json"
+  _native_lib_file =
+      rebase_path("$root_gen_dir/CHROME_VERSION.json", root_out_dir)
+  native_lib_version_arg = "@FileArg($_native_lib_file:full-quoted)"
   asset_location = chrome_shell_assets_dir
 
   #TODO(GYP):
   #'variables': {
   #'conditions': [
   #['component != "shared_library" and target_arch != "arm64" and target_arch != "x64" and profiling_full_stack_frames != 1', {
   ## Only enable the chromium linker on regular builds, since the
   ## component build crashes on Android 4.4. See b/11379966
   #'use_chromium_linker': '1',
   #}],
@@ skipping 299 matching lines @@
   #],
 }
 
 android_apk("chrome_public_apk") {
   version_name = "Developer Build"
   version_code = "1"
   android_manifest = get_target_outputs(":chrome_public_apk_manifest")
   android_manifest = android_manifest[1]
   apk_name = "ChromePublic"
   native_libs = [ "$root_build_dir/lib.stripped/libchrome_public.so" ]
-  native_lib_version_name = _version_full
+  native_lib_version_rule = "//build/util:chrome_version_json"
+  _native_lib_file =
+      rebase_path("$root_gen_dir/CHROME_VERSION.json", root_out_dir)
+  native_lib_version_arg = "@FileArg($_native_lib_file:full-quoted)"
   asset_location = chrome_public_apk_assets_dir
 
   deps = [
     ":chrome_java",
     ":chrome_java_resources",
     ":chrome_public",
     ":chrome_public_apk_assets",
     ":chrome_public_apk_manifest",
     ":chrome_public_template_resources",
     "//base:base_java",
@@ skipping 16 matching lines @@
   # TODO(GYP,cjhopman): Does this need version code/name?
   apk_name = "ChromePublicTest"
   apk_under_test = ":chrome_public_apk"
   android_manifest = chrome_public_test_apk_manifest
   deps = [
     ":chrome_public_test_apk_manifest",
     "//chrome/android:chrome_shared_test_java",
   ]
   isolate_file = "../chrome_public_test_apk.isolate"
 }