Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1228553010: Remove skia_arch_width, fold into skia_arch_type. (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
scroggo, borenet, mtklein
CC:
reviews_skia.org, egdaniel
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Patch Set 3 : Address comment #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -40 lines) Patch
M gyp/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M gyp/everything.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gyp/libjpeg-turbo.gyp View 1 2 3 1 chunk +10 lines, -13 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M site/user/quick/linux.md View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bsalomon
Needs some corresponding changes to the slave scripts (eliminating skia_arch_width specifications and changing skia_arch_type from ...
5 years, 5 months ago (2015-07-08 18:58:08 UTC) #2
mtklein
lgtm (mod bot issues) https://codereview.chromium.org/1228553010/diff/1/gyp/everything.gyp File gyp/everything.gyp (right): https://codereview.chromium.org/1228553010/diff/1/gyp/everything.gyp#newcode23 gyp/everything.gyp:23: ['skia_os in ("ios", "android", "chromeos") ...
5 years, 5 months ago (2015-07-09 16:29:57 UTC) #3
borenet
LGTM as well. I suggest landing like this: 1. Create a change to gyp_defs_from_builder_dict in ...
5 years, 5 months ago (2015-07-13 13:44:36 UTC) #4
bsalomon
On 2015/07/13 13:44:36, borenet wrote: > LGTM as well. I suggest landing like this: > ...
5 years, 5 months ago (2015-07-14 15:39:23 UTC) #7
bsalomon
On 2015/07/13 13:44:36, borenet wrote: > LGTM as well. I suggest landing like this: > ...
5 years, 5 months ago (2015-07-14 17:51:58 UTC) #8
bsalomon
Committed patchset #4 (id:80001) manually as 4239fc2f69bdbd1a1f01ee66112f46033b47b743.
5 years, 4 months ago (2015-07-27 13:10:46 UTC) #9
bsalomon
5 years, 4 months ago (2015-07-27 13:11:04 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1228553010/diff/1/gyp/everything.gyp
File gyp/everything.gyp (right):

https://codereview.chromium.org/1228553010/diff/1/gyp/everything.gyp#newcode23
gyp/everything.gyp:23: ['skia_os in ("ios", "android", "chromeos") or (skia_os
== "mac" and skia_arch_type == "x86")', {
On 2015/07/09 16:29:57, mtklein wrote:
> Let's kill off this clause?  We don't do 32-bit Mac builds anymore.

Done.

Powered by Google App Engine
This is Rietveld 408576698