Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: gyp/common_conditions.gypi

Issue 1228553010: Remove skia_arch_width, fold into skia_arch_type. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 2c88a973f9c738f42eb32e54e074e5c1ef13b822..0138bcf90acb001e18317369b605eff6b4855dc9 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -162,10 +162,10 @@
},
},
}],
- [ 'skia_arch_width == 64', {
+ [ 'skia_arch_type == "x86_64"', {
'msvs_configuration_platform': 'x64',
}],
- [ 'skia_arch_width == 32', {
+ [ 'skia_arch_type == "x86"', {
'msvs_configuration_platform': 'Win32',
}],
[ 'skia_warnings_as_errors', {
@@ -295,7 +295,7 @@
}],
],
}],
- [ 'skia_arch_type == "mips"', {
+ [ '"mips" in skia_arch_type', {
'cflags': [
'-EL',
],
@@ -504,8 +504,8 @@
'conditions': [
[ 'skia_fast', { 'WARNING_CFLAGS': [ '<@(skia_fast_flags)' ] } ],
[ 'skia_warnings_as_errors', { 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES' }],
- [ 'skia_arch_width == 32', { 'ARCHS': ['i386'] }],
- [ 'skia_arch_width == 64', { 'ARCHS': ['x86_64'] }],
+ [ 'skia_arch_type == "x86"', { 'ARCHS': ['i386'] }],
+ [ 'skia_arch_type == "x86_64"', { 'ARCHS': ['x86_64'] }],
[ 'skia_osx_deployment_target==""', {
'MACOSX_DEPLOYMENT_TARGET': '10.6', # -mmacos-version-min, passed in env to ld.
}, {
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698