Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: gyp/common_conditions.gypi

Issue 1228553010: Remove skia_arch_width, fold into skia_arch_type. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 Google Inc. 1 # Copyright 2015 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # conditions used in both common.gypi and skia.gyp in chromium 6 # conditions used in both common.gypi and skia.gyp in chromium
7 # 7 #
8 { 8 {
9 'defines': [ 9 'defines': [
10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 'inherit_from': ['Release_Developer'], 155 'inherit_from': ['Release_Developer'],
156 'msvs_settings': { 156 'msvs_settings': {
157 'VCCLCompilerTool': { 157 'VCCLCompilerTool': {
158 # Don't specify /arch. SSE2 is implied by 64bit and specify ing it warns. 158 # Don't specify /arch. SSE2 is implied by 64bit and specify ing it warns.
159 'EnableEnhancedInstructionSet': '0', # 159 'EnableEnhancedInstructionSet': '0', #
160 }, 160 },
161 }, 161 },
162 }, 162 },
163 }, 163 },
164 }], 164 }],
165 [ 'skia_arch_width == 64', { 165 [ 'skia_arch_type == "x86_64"', {
166 'msvs_configuration_platform': 'x64', 166 'msvs_configuration_platform': 'x64',
167 }], 167 }],
168 [ 'skia_arch_width == 32', { 168 [ 'skia_arch_type == "x86"', {
169 'msvs_configuration_platform': 'Win32', 169 'msvs_configuration_platform': 'Win32',
170 }], 170 }],
171 [ 'skia_warnings_as_errors', { 171 [ 'skia_warnings_as_errors', {
172 'msvs_settings': { 172 'msvs_settings': {
173 'VCCLCompilerTool': { 173 'VCCLCompilerTool': {
174 'WarnAsError': 'true', 174 'WarnAsError': 'true',
175 'AdditionalOptions': [ 175 'AdditionalOptions': [
176 '/we4189', # initialized but unused var warning 176 '/we4189', # initialized but unused var warning
177 ], 177 ],
178 }, 178 },
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 'SK_ARM_HAS_OPTIONAL_NEON', 288 'SK_ARM_HAS_OPTIONAL_NEON',
289 ], 289 ],
290 }], 290 }],
291 [ 'skia_os != "chromeos" and skia_os != "linux"', { 291 [ 'skia_os != "chromeos" and skia_os != "linux"', {
292 'cflags': [ 292 'cflags': [
293 '-mfloat-abi=softfp', 293 '-mfloat-abi=softfp',
294 ], 294 ],
295 }], 295 }],
296 ], 296 ],
297 }], 297 }],
298 [ 'skia_arch_type == "mips"', { 298 [ '"mips" in skia_arch_type', {
299 'cflags': [ 299 'cflags': [
300 '-EL', 300 '-EL',
301 ], 301 ],
302 'conditions': [ 302 'conditions': [
303 [ 'mips_arch_variant == "mips32r2"', { 303 [ 'mips_arch_variant == "mips32r2"', {
304 'cflags': [ 304 'cflags': [
305 '-march=mips32r2', 305 '-march=mips32r2',
306 ], 306 ],
307 'conditions': [ 307 'conditions': [
308 [ 'mips_dsp == 1', { 308 [ 'mips_dsp == 1', {
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 }, 497 },
498 'Release': { 498 'Release': {
499 'xcode_settings': { 'GCC_OPTIMIZATION_LEVEL': '<(skia_release_optimi zation_level)', }, 499 'xcode_settings': { 'GCC_OPTIMIZATION_LEVEL': '<(skia_release_optimi zation_level)', },
500 'defines': [ 'NDEBUG' ], 500 'defines': [ 'NDEBUG' ],
501 }, 501 },
502 }, 502 },
503 'xcode_settings': { 503 'xcode_settings': {
504 'conditions': [ 504 'conditions': [
505 [ 'skia_fast', { 'WARNING_CFLAGS': [ '<@(skia_fast_flags)' ] } ], 505 [ 'skia_fast', { 'WARNING_CFLAGS': [ '<@(skia_fast_flags)' ] } ],
506 [ 'skia_warnings_as_errors', { 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES' }], 506 [ 'skia_warnings_as_errors', { 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES' }],
507 [ 'skia_arch_width == 32', { 'ARCHS': ['i386'] }], 507 [ 'skia_arch_type == "x86"', { 'ARCHS': ['i386'] }],
508 [ 'skia_arch_width == 64', { 'ARCHS': ['x86_64'] }], 508 [ 'skia_arch_type == "x86_64"', { 'ARCHS': ['x86_64'] }],
509 [ 'skia_osx_deployment_target==""', { 509 [ 'skia_osx_deployment_target==""', {
510 'MACOSX_DEPLOYMENT_TARGET': '10.6', # -mmacos-version-min, passed in env to ld. 510 'MACOSX_DEPLOYMENT_TARGET': '10.6', # -mmacos-version-min, passed in env to ld.
511 }, { 511 }, {
512 'MACOSX_DEPLOYMENT_TARGET': '<(skia_osx_deployment_target)', 512 'MACOSX_DEPLOYMENT_TARGET': '<(skia_osx_deployment_target)',
513 }], 513 }],
514 ], 514 ],
515 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', 515 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
516 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3 516 'GCC_ENABLE_SUPPLEMENTAL_SSE3_INSTRUCTIONS': 'YES', # -mssse3
517 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hi dden 517 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # -fvisibility=hi dden
518 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-in lines-hidden 518 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO', # -fvisibility-in lines-hidden
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 [ 'sknx_no_simd', { 640 [ 'sknx_no_simd', {
641 'defines': [ 'SKNX_NO_SIMD' ], 641 'defines': [ 'SKNX_NO_SIMD' ],
642 }], 642 }],
643 643
644 ], # end 'conditions' 644 ], # end 'conditions'
645 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details 645 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
646 'xcode_settings': { 646 'xcode_settings': {
647 'SYMROOT': '<(DEPTH)/xcodebuild', 647 'SYMROOT': '<(DEPTH)/xcodebuild',
648 }, 648 },
649 } 649 }
OLDNEW
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698