Issue 1228463002: Remove RenderImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228463002: Remove RenderImage (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove RenderImage This CL removes RenderImage and all the other remaining uses of ImageResource from sky/engine/core/rendering. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/10368c45560bb2ced4888fe6140e5b9a1cd26dce

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -772 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/editing/Editor.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/editing/TextIterator.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/fetch/ImageResource.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/fetch/ImageResourceClient.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/loader/ImageLoader.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/loader/ImageLoader.cpp	View	4 chunks	+0 lines, -33 lines	0 comments	Download
M	sky/engine/core/rendering/HitTestResult.cpp	View	2 chunks	+2 lines, -11 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImage.h	View	1 chunk	+0 lines, -86 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImage.cpp	View	1 chunk	+0 lines, -246 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImageResource.h	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImageResource.cpp	View	1 chunk	+0 lines, -108 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImageResourceStyleImage.h	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	sky/engine/core/rendering/RenderImageResourceStyleImage.cpp	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	4 chunks	+1 line, -7 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.cpp	View	4 chunks	+1 line, -22 lines	0 comments	Download
M	sky/engine/core/rendering/RenderReplaced.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/style/ShapeValue.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleImage.h	View	2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-05 21:35:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10368c45560bb2ced4888fe6140e5b9a1cd26dce (presubmit successful).

Expand Messages | Collapse Messages