Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: sky/engine/core/rendering/RenderObject.h

Issue 1228463002: Remove RenderImage (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderObject.h
diff --git a/sky/engine/core/rendering/RenderObject.h b/sky/engine/core/rendering/RenderObject.h
index b07c15c6be81a7ae24cf6077223b8791e695be78..14ca33720330f7a1dd663c131db2fa05015c011e 100644
--- a/sky/engine/core/rendering/RenderObject.h
+++ b/sky/engine/core/rendering/RenderObject.h
@@ -30,7 +30,6 @@
#include "sky/engine/core/dom/DocumentLifecycle.h"
#include "sky/engine/core/dom/Element.h"
#include "sky/engine/core/editing/TextAffinity.h"
-#include "sky/engine/core/fetch/ImageResourceClient.h"
#include "sky/engine/core/html/HTMLElement.h"
#include "sky/engine/core/rendering/HitTestRequest.h"
#include "sky/engine/core/rendering/RenderObjectChildList.h"
@@ -102,7 +101,7 @@ const int showTreeCharacterOffset = 39;
#endif
// Base class for all rendering tree objects.
-class RenderObject : public ImageResourceClient {
+class RenderObject {
friend class RenderBlock;
friend class RenderObjectChildList;
WTF_MAKE_NONCOPYABLE(RenderObject);
@@ -253,7 +252,6 @@ public:
virtual bool isRenderBlock() const { return false; }
virtual bool isRenderCustomLayout() const { return false; }
virtual bool isRenderParagraph() const { return false; }
- virtual bool isRenderImage() const { return false; }
virtual bool isRenderInline() const { return false; }
virtual bool isRenderView() const { return false; }
@@ -557,10 +555,6 @@ public:
virtual int previousOffsetForBackwardDeletion(int current) const;
virtual int nextOffset(int current) const;
- virtual void imageChanged(ImageResource*, const IntRect* = 0) override final;
- virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
- virtual bool willRenderImage(ImageResource*) override final;
-
void selectionStartEnd(int& spos, int& epos) const;
void remove() { if (parent()) parent()->removeChild(this); }
« no previous file with comments | « sky/engine/core/rendering/RenderImageResourceStyleImage.cpp ('k') | sky/engine/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698