Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1228333003: Replace buggy_blend_modes GM with an exhaustive test. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace buggy_blend_modes GM with an exhaustive test. The new test is disabled by default, as it's quite slow. We can run it if we suspect problems by passing -x to DM. This test would have been failing before the bug fix, and now is passing. Assuming the Priv on the end means it's not considered public API... TBR=reed@google.com BUG=skia:4052 Committed: https://skia.googlesource.com/skia/+/767d273ea0948e4f61d318bec58ce417cdc470df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -52 lines) Patch
D gm/buggy_blend_modes.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M include/core/SkColorPriv.h View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/BlendTest.cpp View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mtklein_C
5 years, 5 months ago (2015-07-14 21:54:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333003/1
5 years, 5 months ago (2015-07-14 21:56:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 22:07:31 UTC) #6
f(malita)
lgtm
5 years, 5 months ago (2015-07-14 22:27:39 UTC) #7
mtklein
Just to be paranoid I'm going to wait for the bots to finish running the ...
5 years, 5 months ago (2015-07-14 22:29:35 UTC) #9
mtklein
On 2015/07/14 22:29:35, mtklein wrote: > Just to be paranoid I'm going to wait for ...
5 years, 5 months ago (2015-07-15 14:20:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228333003/1
5 years, 5 months ago (2015-07-16 13:32:41 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 14:01:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/767d273ea0948e4f61d318bec58ce417cdc470df

Powered by Google App Engine
This is Rietveld 408576698