Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: gm/buggy_blend_modes.cpp

Issue 1228333003: Replace buggy_blend_modes GM with an exhaustive test. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/core/SkColorPriv.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/buggy_blend_modes.cpp
diff --git a/gm/buggy_blend_modes.cpp b/gm/buggy_blend_modes.cpp
deleted file mode 100644
index 21a6798fe07d083a3b5e54ed455fa4d962e43de0..0000000000000000000000000000000000000000
--- a/gm/buggy_blend_modes.cpp
+++ /dev/null
@@ -1,52 +0,0 @@
-/*
- * Copyright 2015 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#include "SkCanvas.h"
-#include "SkGradientShader.h"
-#include "gm.h"
-
-// This GM reproduces what I think are overflow bugs in the CPU implementations of a
-// couple xfermodes. I've marked non-obvious keys to reproducing the bug // Essential!
-DEF_SIMPLE_GM(buggy_blend_modes, canvas, 800, 200) {
- const auto tiling = SkShader::kClamp_TileMode;
- const auto flags = SkGradientShader::kInterpolateColorsInPremul_Flag; // Essential!
-
- SkAutoTUnref<SkShader> cyanH, magentaV;
- {
- SkPoint pts[] = { {0,0}, {200, 0} };
- SkColor colors[] = { 0x00000000, 0xFF00FFFF };
- cyanH.reset(
- SkGradientShader::CreateLinear(pts, colors, nullptr, 2, tiling, flags, nullptr));
- }
- {
- SkPoint pts[] = { {0,0}, {0, 200} };
- SkColor colors[] = { 0x00000000, 0xFFFF00FF };
- magentaV.reset(
- SkGradientShader::CreateLinear(pts, colors, nullptr, 2, tiling, flags, nullptr));
- }
-
- SkXfermode::Mode modes[] = {
- SkXfermode::kDarken_Mode, // Looks ok?
- SkXfermode::kHardLight_Mode, // Definitely wrong.
- SkXfermode::kLighten_Mode, // Definitely wrong.
- SkXfermode::kOverlay_Mode, // Same code as kHardLight_Mode.
- };
-
- canvas->clear(SK_ColorWHITE);
- for (auto mode : modes) {
- canvas->saveLayer(nullptr, nullptr); // Essential!
- SkPaint h, v;
- h.setShader(cyanH);
- v.setShader(magentaV);
- v.setXfermodeMode(mode);
- canvas->drawRect(SkRect::MakeWH(200,200), h);
- canvas->drawRect(SkRect::MakeWH(200,200), v);
- canvas->restore();
-
- canvas->translate(200, 0);
- }
-}
« no previous file with comments | « no previous file | include/core/SkColorPriv.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698