Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/auxiliary_profile_loader_impl_android.h

Index: chrome/browser/autofill/auxiliary_profile_loader_impl_android.h
diff --git a/chrome/browser/autofill/auxiliary_profile_loader_impl_android.h b/chrome/browser/autofill/auxiliary_profile_loader_impl_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..7dccf7e905a0306f73ee7e7fc3b1b4ee483481aa
--- /dev/null
+++ b/chrome/browser/autofill/auxiliary_profile_loader_impl_android.h
@@ -0,0 +1,37 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_
+#define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_
+
+#include "base/android/jni_android.h"
+#include "chrome/browser/autofill/auxiliary_profile_loader.h"
+
+bool RegisterAuxiliaryProfileLoader(JNIEnv* env);

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+class AuxiliaryProfileLoaderImplAndroid : public AuxiliaryProfileLoader {

[Ilya Sherman, 2013/03/01 01:55:04]

Why have the parent class if there's only one implementation class?

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[apiccion, 2013/03/02 03:37:01]

It's an abstract interface.
On 2013/03/01 01:55:04, Ilya Sherman wrote:

+ public:
+  explicit AuxiliaryProfileLoaderImplAndroid();

[Ilya Sherman, 2013/03/01 01:55:04]

nit: No need for explicit.

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Include an explicitly defined destructor.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+  // AuxiliaryProfileLoader implementation
+  virtual string16 GetStreet() OVERRIDE;
+  virtual string16 GetPobox() OVERRIDE;
+  virtual string16 GetNeighborhood() OVERRIDE;
+  virtual string16 GetRegion() OVERRIDE;
+  virtual string16 GetCity() OVERRIDE;
+  virtual string16 GetPostalCode() OVERRIDE;
+  virtual string16 GetCountry() OVERRIDE;
+  virtual string16 GetFirstName() OVERRIDE;
+  virtual string16 GetMiddleName() OVERRIDE;
+  virtual string16 GetLastName() OVERRIDE;
+  virtual string16 GetSuffix() OVERRIDE;
+  virtual std::vector<string16> GetEmailAddresses() OVERRIDE;
+  virtual std::vector<string16> GetPhoneNumbers() OVERRIDE;
+
+ private:
+  base::android::ScopedJavaLocalRef<jobject> populator_;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[apiccion, 2013/03/02 03:37:01]

Done.

+  JNIEnv* env_;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[apiccion, 2013/03/02 03:37:01]

Done.

+  DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfileLoaderImplAndroid);
+};
+#endif  // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_