Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/auxiliary_profile_loader.h

Index: chrome/browser/autofill/auxiliary_profile_loader.h
diff --git a/chrome/browser/autofill/auxiliary_profile_loader.h b/chrome/browser/autofill/auxiliary_profile_loader.h
new file mode 100644
index 0000000000000000000000000000000000000000..ba73fbb40ddbc2cd81128eee4fb3895640f20f4f
--- /dev/null
+++ b/chrome/browser/autofill/auxiliary_profile_loader.h
@@ -0,0 +1,37 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_
+#define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_

[Ilya Sherman, 2013/03/01 01:55:04]

Is this class used for any platforms other than Android?  If not, please move it
to an android/ subdirectory, and make sure that it's only compiled on that
platform.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+#include <vector>

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Leave a blank line after this one.

[apiccion, 2013/03/02 03:37:01]

Done.

+#include "base/string16.h"
+
+class AuxiliaryProfileLoader {

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Docs.

[Ilya Sherman, 2013/03/01 01:55:04]

nit: This class should be in the autofill:: namespace.  This comment applies to
the contents of all the new header files introduced in this CL.

[apiccion, 2013/03/02 03:37:01]

Done.

+ public:
+  virtual ~AuxiliaryProfileLoader() {}
+
+  // Address info

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Please include docs for each method in this class.

[apiccion, 2013/03/02 03:37:01]

Done.

[apiccion, 2013/03/02 03:37:01]

Done.

+  virtual string16 GetStreet() = 0;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Should this and all of the other Get() methods be const?

[apiccion, 2013/03/02 03:37:01]

Done.

[apiccion, 2013/03/02 03:37:01]

Done.

+  virtual string16 GetPobox() = 0;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Please spell out "GetPostOfficeBox()"

[apiccion, 2013/03/02 03:37:01]

Done.

+  virtual string16 GetNeighborhood() = 0;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: I have no idea what this method returns.  This is why per-method docs are
useful.

[apiccion, 2013/03/02 03:37:01]

Done.

+  virtual string16 GetRegion() = 0;
+  virtual string16 GetCity() = 0;
+  virtual string16 GetPostalCode() = 0;
+  virtual string16 GetCountry() = 0;
+
+  // Name info
+  virtual string16 GetFirstName() = 0;
+  virtual string16 GetMiddleName() = 0;
+  virtual string16 GetLastName() = 0;
+  virtual string16 GetSuffix() = 0;
+
+  // Email info
+  virtual std::vector<string16> GetEmailAddresses() = 0;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Please make this method signature be

virtual void GetEmailAddresses(std::vector<string16>* email_addresses) = 0;

[apiccion, 2013/03/02 03:37:01]

Done.

+
+  // Phone info
+  virtual std::vector<string16> GetPhoneNumbers() = 0;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Ditto: use an outparam rather than returning a vector.

[apiccion, 2013/03/02 03:37:01]

Done.

+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_