chrome/browser/autofill/auxiliary_profile_loader_impl_android.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff: chrome/browser/autofill/auxiliary_profile_loader_impl_android.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Autofill nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/auxiliary_profile_loader.h ('K') | « chrome/browser/autofill/auxiliary_profile_loader.h ('k') | chrome/browser/autofill/auxiliary_profile_loader_impl_android.cc » ('j') | chrome/browser/autofill/auxiliary_profile_loader_impl_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_

	7

	8 #include "base/android/jni_android.h"

	9 #include "chrome/browser/autofill/auxiliary_profile_loader.h"

	10

	11 bool RegisterAuxiliaryProfileLoader(JNIEnv* env);
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	12

	13 class AuxiliaryProfileLoaderImplAndroid : public AuxiliaryProfileLoader {
	Ilya Sherman 2013/03/01 01:55:04 Why have the parent class if there's only one impl Why have the parent class if there's only one implementation class? Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 It's an abstract interface. On 2013/03/01 01:55:04 It's an abstract interface. On 2013/03/01 01:55:04, Ilya Sherman wrote: Show quoted text > Why have the parent class if there's only one implementation class?
	14 public:

	15 explicit AuxiliaryProfileLoaderImplAndroid();
	Ilya Sherman 2013/03/01 01:55:04 nit: No need for explicit. nit: No need for explicit. Ilya Sherman 2013/03/01 01:55:04 nit: Include an explicitly defined destructor. nit: Include an explicitly defined destructor. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Include an explicitly defined destructor. Done.
	16

	17 // AuxiliaryProfileLoader implementation

	18 virtual string16 GetStreet() OVERRIDE;

	19 virtual string16 GetPobox() OVERRIDE;

	20 virtual string16 GetNeighborhood() OVERRIDE;

	21 virtual string16 GetRegion() OVERRIDE;

	22 virtual string16 GetCity() OVERRIDE;

	23 virtual string16 GetPostalCode() OVERRIDE;

	24 virtual string16 GetCountry() OVERRIDE;

	25 virtual string16 GetFirstName() OVERRIDE;

	26 virtual string16 GetMiddleName() OVERRIDE;

	27 virtual string16 GetLastName() OVERRIDE;

	28 virtual string16 GetSuffix() OVERRIDE;

	29 virtual std::vector<string16> GetEmailAddresses() OVERRIDE;

	30 virtual std::vector<string16> GetPhoneNumbers() OVERRIDE;

	31

	32 private:

	33 base::android::ScopedJavaLocalRef<jobject> populator_;
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	34 JNIEnv* env_;
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	35 DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfileLoaderImplAndroid);

	36 };

	37 #endif // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_IMPL_ANDROID_H_

OLD	NEW