chrome/browser/autofill/auxiliary_profile_loader.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff: chrome/browser/autofill/auxiliary_profile_loader.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Autofill nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/auxiliary_profile_impl_unittest.cc ('K') | « chrome/browser/autofill/auxiliary_profile_impl_unittest.cc ('k') | chrome/browser/autofill/auxiliary_profile_loader_impl_android.h » ('j') | chrome/browser/autofill/auxiliary_profile_loader_impl_android.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_
	Ilya Sherman 2013/03/01 01:55:04 Is this class used for any platforms other than An Is this class used for any platforms other than Android? If not, please move it to an android/ subdirectory, and make sure that it's only compiled on that platform. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > Is this class used for any platforms other than Android? If not, please move it > to an android/ subdirectory, and make sure that it's only compiled on that > platform. Done.
	7

	8 #include <vector>
	Ilya Sherman 2013/03/01 01:55:04 nit: Leave a blank line after this one. nit: Leave a blank line after this one. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Leave a blank line after this one. Done.
	9 #include "base/string16.h"

	10

	11 class AuxiliaryProfileLoader {
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. Ilya Sherman 2013/03/01 01:55:04 nit: This class should be in the autofill:: namesp nit: This class should be in the autofill:: namespace. This comment applies to the contents of all the new header files introduced in this CL. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: This class should be in the autofill:: namespace. This comment applies to > the contents of all the new header files introduced in this CL. Done.
	12 public:

	13 virtual ~AuxiliaryProfileLoader() {}

	14

	15 // Address info
	Ilya Sherman 2013/03/01 01:55:04 nit: Please include docs for each method in this c nit: Please include docs for each method in this class. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Please include docs for each method in this class. Done. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Please include docs for each method in this class. Done.
	16 virtual string16 GetStreet() = 0;
	Ilya Sherman 2013/03/01 01:55:04 nit: Should this and all of the other Get() method nit: Should this and all of the other Get() methods be const? apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Should this and all of the other Get() methods be const? Done. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Should this and all of the other Get() methods be const? Done.
	17 virtual string16 GetPobox() = 0;
	Ilya Sherman 2013/03/01 01:55:04 nit: Please spell out "GetPostOfficeBox()" nit: Please spell out "GetPostOfficeBox()" apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Please spell out "GetPostOfficeBox()" Done.
	18 virtual string16 GetNeighborhood() = 0;
	Ilya Sherman 2013/03/01 01:55:04 nit: I have no idea what this method returns. Thi nit: I have no idea what this method returns. This is why per-method docs are useful. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: I have no idea what this method returns. This is why per-method docs are > useful. Done.
	19 virtual string16 GetRegion() = 0;

	20 virtual string16 GetCity() = 0;

	21 virtual string16 GetPostalCode() = 0;

	22 virtual string16 GetCountry() = 0;

	23

	24 // Name info

	25 virtual string16 GetFirstName() = 0;

	26 virtual string16 GetMiddleName() = 0;

	27 virtual string16 GetLastName() = 0;

	28 virtual string16 GetSuffix() = 0;

	29

	30 // Email info

	31 virtual std::vector<string16> GetEmailAddresses() = 0;
	Ilya Sherman 2013/03/01 01:55:04 nit: Please make this method signature be virtual nit: Please make this method signature be virtual void GetEmailAddresses(std::vector<string16>* email_addresses) = 0; apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Please make this method signature be > > virtual void GetEmailAddresses(std::vector<string16>* email_addresses) = 0; Done.
	32

	33 // Phone info

	34 virtual std::vector<string16> GetPhoneNumbers() = 0;
	Ilya Sherman 2013/03/01 01:55:04 nit: Ditto: use an outparam rather than returning nit: Ditto: use an outparam rather than returning a vector. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Ditto: use an outparam rather than returning a vector. Done.
	35 };

	36

	37 #endif // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_H_

OLD	NEW