Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1228063003: fix for 1.12.0-dev SDK and 0.25.1 analyzer breaking changes (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix for 1.12.0-dev SDK and 0.25.1 analyzer breaking changes unfortunately we can't run on stable anymore R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a0bbaf6469a7180c20ecc4a1442bfa03929b7cac

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -58 lines) Patch
M .gitignore View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/checker/resolver.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M lib/src/codegen/ast_builder.dart View 3 chunks +5 lines, -4 lines 1 comment Download
M lib/src/codegen/reify_coercions.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +3 lines, -1 line 0 comments Download
M lib/src/info.dart View 1 chunk +1 line, -2 lines 2 comments Download
M lib/src/multi_package_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/testing.dart View 1 chunk +1 line, -1 line 1 comment Download
M lib/strong_mode.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 1 comment Download
M test/checker/checker_test.dart View 1 chunk +34 lines, -32 lines 0 comments Download
M tool/patch_sdk.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
https://codereview.chromium.org/1228063003/diff/1/lib/src/codegen/ast_builder.dart File lib/src/codegen/ast_builder.dart (right): https://codereview.chromium.org/1228063003/diff/1/lib/src/codegen/ast_builder.dart#newcode432 lib/src/codegen/ast_builder.dart:432: return new FunctionExpressionInvocation(function, null, es); the `null` is for ...
5 years, 5 months ago (2015-07-09 17:03:29 UTC) #2
vsm
lgtm https://codereview.chromium.org/1228063003/diff/1/lib/src/info.dart File lib/src/info.dart (right): https://codereview.chromium.org/1228063003/diff/1/lib/src/info.dart#newcode447 lib/src/info.dart:447: ClassElement get parent => element.enclosingElement; On 2015/07/09 17:03:29, ...
5 years, 5 months ago (2015-07-09 17:09:56 UTC) #3
Jennifer Messerly
5 years, 5 months ago (2015-07-09 17:11:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a0bbaf6469a7180c20ecc4a1442bfa03929b7cac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698