lib/src/codegen/side_effect_analysis.dart - Issue 1228063003: fix for 1.12.0-dev SDK and 0.25.1 analyzer breaking changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/side_effect_analysis.dart

Issue 1228063003: fix for 1.12.0-dev SDK and 0.25.1 analyzer breaking changes (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/side_effect_analysis.dart

diff --git a/lib/src/codegen/side_effect_analysis.dart b/lib/src/codegen/side_effect_analysis.dart

index df355d8bc4ed6559f7cd047907428b05286dbba3..dd72d0167623d6ec1586e42ff59602d8f40bcd8c 100644

--- a/lib/src/codegen/side_effect_analysis.dart

+++ b/lib/src/codegen/side_effect_analysis.dart

@@ -96,7 +96,9 @@ class ConstFieldVisitor {

final ConstantVisitor _constantVisitor;

ConstFieldVisitor(TypeProvider types, CompilationUnit unit)

- : _constantVisitor = new ConstantVisitor.con1(types,

+ // TODO(jmesserly): support -D variables on the command line

+ : _constantVisitor = new ConstantVisitor(

+ new ConstantEvaluationEngine(types, new DeclaredVariables()),

new ErrorReporter(new RecordingErrorListener(), unit.element.source));

// TODO(jmesserly): this is used to determine if the field initialization is