fix for 1.12.0-dev SDK and 0.25.1 analyzer breaking changes

test/checker/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// General type checking tests
 library dev_compiler.test.checker_test;
 
 import 'package:test/test.dart';
 
 import 'package:dev_compiler/src/testing.dart';
@@ skipping 818 matching lines @@
         }
       }
    '''
     });
   });
 
   test('Function typing and subtyping: higher order function variables', () {
     testChecker({
       '/main.dart': '''
 
-      class A {}
-      class B extends A {}
+    class A {}
+    class B extends A {}
 
-      typedef T Function2<S, T>(S z);
+    typedef T Function2<S, T>(S z);
 
-      void main() {
-        {
-          Function2<Function2<A, B>, Function2<B, A>> top;
-          Function2<Function2<B, A>, Function2<B, A>> right;
-          Function2<Function2<A, B>, Function2<A, B>> left;
-          Function2<Function2<B, A>, Function2<A, B>> bot;
+    void main() {
+      {
+        Function2<Function2<A, B>, Function2<B, A>> top;
+        Function2<Function2<B, A>, Function2<B, A>> right;
+        Function2<Function2<A, B>, Function2<A, B>> left;
+        Function2<Function2<B, A>, Function2<A, B>> bot;
 
-          top = right;
-          top = bot;
-          top = top;
-          top = left;
+        top = right;
+        top = bot;
+        top = top;
+        top = left;
 
-          left = /*pass should be warning:DownCastComposite*/top;
-          left = left;
-          left = /*pass should be severe:StaticTypeError*/right;
-          left = bot;
+        left = /*warning:DownCastComposite*/top;
+        left = left;
+        left =
+            /*warning:DownCastComposite should be severe:StaticTypeError*/right;
+        left = bot;
 
-          right = /*pass should be warning:DownCastComposite*/top;
-          right = /*pass should be severe:StaticTypeError*/left;
-          right = right;
-          right = bot;
+        right = /*warning:DownCastComposite*/top;
+        right =
+            /*warning:DownCastComposite should be severe:StaticTypeError*/left;
+        right = right;
+        right = bot;
 
-          bot = /*pass should be warning:DownCastComposite*/top;
-          bot = /*pass should be warning:DownCastComposite*/left;
-          bot = /*pass should be warning:DownCastComposite*/right;
-          bot = bot;
-        }
+        bot = /*warning:DownCastComposite*/top;
+        bot = /*warning:DownCastComposite*/left;
+        bot = /*warning:DownCastComposite*/right;
+        bot = bot;
       }
+    }
    '''
     });
   });
 
   test('Function typing and subtyping: named and optional parameters', () {
     testChecker({
       '/main.dart': '''
 
       class A {}
 
@@ skipping 1849 matching lines @@
 
         baz1() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable baz2() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable<int> baz3() sync* { yield* (/*warning:DownCastComposite*/x); }
         Iterable<int> baz4() sync* { yield* new Iterable<int>(); }
         Iterable<int> baz5() sync* { yield* (/*info:InferredTypeAllocation*/new Iterable()); }
     '''
     }));
   });
 }