TypeofMode replaces TypeofState and ContextualMode.

TypeofMode replaces TypeofState and ContextualMode.

NON_CONTEXTUAL ~> INSIDE_TYPEOF
CONTEXTUAL ~> NOT_INSIDE_TYPEOF

Committed: https://crrev.com/fec3c9cba647da29fb499242b7b2cf2fccf297b0
Cr-Commit-Position: refs/heads/master@{#29611}

[Igor Sheludko, 2015-07-09 18:30:18]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-07-09 19:00:30]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-07-09 19:00:30]

PTAL

[Toon Verwaest, 2015-07-10 15:41:31]

Very nice cleanup, I've wanted this for quite a while.
Seems like there's still some stuff not exactly correct, unless I missed
something.

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode738
src/ic/ic.cc:738: if (it.IsFound() || typeof_mode() == INSIDE_TYPEOF) {
typeof_mode() == INSIDE_TYPEOF is not the same as !IsUndeclaredGlobal(object).
You basically want
it.IsFound() || typeof_mode() == INSIDE_TYPEOF || !object->IsGlobalObject(). If
there was no failing test (seems unlikely?) please add one.

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode749
src/ic/ic.cc:749: } else if (typeof_mode() == INSIDE_TYPEOF) {
Same here.

[Igor Sheludko, 2015-07-13 12:17:10]

Now INSIDE_TYPEOF is used really from Typeof.

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode738
src/ic/ic.cc:738: if (it.IsFound() || typeof_mode() == INSIDE_TYPEOF) {
On 2015/07/10 15:41:31, Toon Verwaest wrote:
> typeof_mode() == INSIDE_TYPEOF is not the same as !IsUndeclaredGlobal(object).
> You basically want
> it.IsFound() || typeof_mode() == INSIDE_TYPEOF || !object->IsGlobalObject().
If
> there was no failing test (seems unlikely?) please add one.

Done.

https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode749
src/ic/ic.cc:749: } else if (typeof_mode() == INSIDE_TYPEOF) {
On 2015/07/10 15:41:31, Toon Verwaest wrote:
> Same here.

Done.

[Toon Verwaest, 2015-07-13 12:56:03]

lgtm with 2 comments

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc#newcode3024
src/ic/ic.cc:3024: return ThrowReferenceError(isolate, &it);
Just inline the helper method here, if it's the only user.

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.h#newcode386
src/ic/ic.h:386: bool IsUndeclaredGlobal(Handle<Object> receiver) {
IsUndeclaredGlobal -> ShouldThrowReferenceError

[Igor Sheludko, 2015-07-13 13:08:02]

Thanks! Landing...

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc#newcode3024
src/ic/ic.cc:3024: return ThrowReferenceError(isolate, &it);
On 2015/07/13 12:56:03, Toon Verwaest wrote:
> Just inline the helper method here, if it's the only user.

Done.

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.h#newcode386
src/ic/ic.h:386: bool IsUndeclaredGlobal(Handle<Object> receiver) {
On 2015/07/13 12:56:03, Toon Verwaest wrote:
> IsUndeclaredGlobal -> ShouldThrowReferenceError

Done.

[Igor Sheludko, 2015-07-13 13:08:08]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-07-13 13:08:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1227893005/#ps100001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-07-13 13:08:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227893005/100001

[commit-bot: I haz the power, 2015-07-13 13:39:34]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-07-13 13:39:54]

Patchset 5 (id:??) landed as
https://crrev.com/fec3c9cba647da29fb499242b7b2cf2fccf297b0
Cr-Commit-Position: refs/heads/master@{#29611}