Issue 122783002: Add Dictionary get() method for AtomicString values and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122783002: Add Dictionary get() method for AtomicString values and use it (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
haraken, eseidel

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add Dictionary get() method for AtomicString values and use it Add Dictionary get() method for AtomicString values and use it in CustomElementConstructorBuilder where the caller actually wants an AtomicString. The code is refactored a bit to avoid code duplication with the String type getter. BUG=323739 R=haraken, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164402

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -2 lines)			Patch
M	Source/bindings/v8/CustomElementConstructorBuilder.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Source/bindings/v8/Dictionary.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/Dictionary.cpp	View	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/122783002/diff/1/Source/bindings/v8/CustomElementConstructorBuilder.cpp File Source/bindings/v8/CustomElementConstructorBuilder.cpp (right): https://codereview.chromium.org/122783002/diff/1/Source/bindings/v8/CustomElementConstructorBuilder.cpp#newcode107 Source/bindings/v8/CustomElementConstructorBuilder.cpp:107: localName = extends.lower(); String -> AtomicString conversion if extends ...

6 years, 11 months ago (2013-12-31 15:43:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/122783002/1

6 years, 11 months ago (2013-12-31 20:38:20 UTC) #3

Message was sent while issue was closed.

Change committed as 164402

Expand Messages | Collapse Messages