Source/bindings/v8/Dictionary.h - Issue 122783002: Add Dictionary get() method for AtomicString values and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 122783002: Add Dictionary get() method for AtomicString values and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/CustomElementConstructorBuilder.cpp ('K') | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/Dictionary.h

diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h

index 3f29651e8762bb673290c9f58c989e0a2483ecb5..172f631ce92f8a3ced81ac77d937fcc87580f3d2 100644

--- a/Source/bindings/v8/Dictionary.h

+++ b/Source/bindings/v8/Dictionary.h

@@ -72,6 +72,7 @@ public:

bool get(const String&, double&, bool& hasValue) const;

bool get(const String&, double&) const;

bool get(const String&, String&) const;

+ bool get(const String&, AtomicString&) const;

bool get(const String&, ScriptValue&) const;

bool get(const String&, short&) const;

bool get(const String&, unsigned short&) const;

@@ -161,6 +162,9 @@ public:

template<typename T>

bool convert(ConversionContext &, const String&, RefPtr<T>&) const;

+ template<typename StringType>

+ bool getStringType(const String&, StringType&) const;

bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;

bool getOwnPropertyNames(Vector<String>&) const;