Source/bindings/v8/CustomElementConstructorBuilder.cpp - Issue 122783002: Add Dictionary get() method for AtomicString values and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/CustomElementConstructorBuilder.cpp

Issue 122783002: Add Dictionary get() method for AtomicString values and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/CustomElementConstructorBuilder.cpp

diff --git a/Source/bindings/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

index 4d8f0ab1df6eebc558441ca08e4291c3bb5b0236..1f3688b6717ec67d7640512bdb8fca1edebeafd6 100644

--- a/Source/bindings/v8/CustomElementConstructorBuilder.cpp

+++ b/Source/bindings/v8/CustomElementConstructorBuilder.cpp

@@ -88,7 +88,7 @@ bool CustomElementConstructorBuilder::validateOptions(const AtomicString& type,

m_prototype->SetPrototype(basePrototype);

}

- String extends;

+ AtomicString extends;

bool extendsProvidedAndNonNull = m_options->get("extends", extends);

if (!V8PerContextData::from(m_context)) {

« no previous file with comments | « no previous file | Source/bindings/v8/Dictionary.h » ('j') | no next file with comments »