Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 12278014: Make base compile with no "using base::FilePath". (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Make base compile with no "using base::FilePath". For base .cc files not using the base namespace, I added a using since theses files should be moved to the base namespace, and then explicit qualification will no longer be necessary. Original review URL: https://codereview.chromium.org/12226121 (reland of r182040). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M base/command_line.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_path.cc View 11 chunks +14 lines, -10 lines 0 comments Download
M base/file_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/json/json_file_value_serializer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/json/json_file_value_serializer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/path_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Sorry I forgot to upload the original patch as a base. The only changes are ...
7 years, 10 months ago (2013-02-15 21:02:05 UTC) #1
jar (doing other things)
7 years, 10 months ago (2013-02-16 00:55:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698