Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: base/json/json_file_value_serializer.h

Issue 12278014: Make base compile with no "using base::FilePath". (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/file_util_posix.cc ('k') | base/json/json_file_value_serializer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 5 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 6 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_export.h" 10 #include "base/base_export.h"
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/file_path.h" 12 #include "base/file_path.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 14
15 class BASE_EXPORT JSONFileValueSerializer : public base::ValueSerializer { 15 class BASE_EXPORT JSONFileValueSerializer : public base::ValueSerializer {
16 public: 16 public:
17 // json_file_patch is the path of a file that will be source of the 17 // json_file_patch is the path of a file that will be source of the
18 // deserialization or the destination of the serialization. 18 // deserialization or the destination of the serialization.
19 // When deserializing, the file should exist, but when serializing, the 19 // When deserializing, the file should exist, but when serializing, the
20 // serializer will attempt to create the file at the specified location. 20 // serializer will attempt to create the file at the specified location.
21 explicit JSONFileValueSerializer(const FilePath& json_file_path) 21 explicit JSONFileValueSerializer(const base::FilePath& json_file_path)
22 : json_file_path_(json_file_path), 22 : json_file_path_(json_file_path),
23 allow_trailing_comma_(false) {} 23 allow_trailing_comma_(false) {}
24 24
25 virtual ~JSONFileValueSerializer() {} 25 virtual ~JSONFileValueSerializer() {}
26 26
27 // DO NOT USE except in unit tests to verify the file was written properly. 27 // DO NOT USE except in unit tests to verify the file was written properly.
28 // We should never serialize directly to a file since this will block the 28 // We should never serialize directly to a file since this will block the
29 // thread. Instead, serialize to a string and write to the file you want on 29 // thread. Instead, serialize to a string and write to the file you want on
30 // the file thread. 30 // the file thread.
31 // 31 //
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // be a JsonFileError. 67 // be a JsonFileError.
68 static const char* GetErrorMessageForCode(int error_code); 68 static const char* GetErrorMessageForCode(int error_code);
69 69
70 void set_allow_trailing_comma(bool new_value) { 70 void set_allow_trailing_comma(bool new_value) {
71 allow_trailing_comma_ = new_value; 71 allow_trailing_comma_ = new_value;
72 } 72 }
73 73
74 private: 74 private:
75 bool SerializeInternal(const Value& root, bool omit_binary_values); 75 bool SerializeInternal(const Value& root, bool omit_binary_values);
76 76
77 FilePath json_file_path_; 77 base::FilePath json_file_path_;
78 bool allow_trailing_comma_; 78 bool allow_trailing_comma_;
79 79
80 // A wrapper for file_util::ReadFileToString which returns a non-zero 80 // A wrapper for file_util::ReadFileToString which returns a non-zero
81 // JsonFileError if there were file errors. 81 // JsonFileError if there were file errors.
82 int ReadFileToString(std::string* json_string); 82 int ReadFileToString(std::string* json_string);
83 83
84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer); 84 DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer);
85 }; 85 };
86 86
87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_ 87 #endif // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
88 88
OLDNEW
« no previous file with comments | « base/file_util_posix.cc ('k') | base/json/json_file_value_serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698