Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 12226121: Make base compile with no "using base::FilePath". (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Make base compile with no "using base::FilePath". For base .cc files not using the base namespace, I added a using since theses files should be moved to the base namespace, and then explicit qualification will no longer be necessary. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182032

Patch Set 1 #

Patch Set 2 : git try #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M base/command_line.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_path.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M base/file_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/json/json_file_value_serializer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/json/json_file_value_serializer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/nix/mime_util_xdg.cc View 1 2 chunks +3 lines, -3 lines 2 comments Download
M base/path_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
7 years, 10 months ago (2013-02-12 19:27:33 UTC) #1
brettw
TBR=jar
7 years, 10 months ago (2013-02-12 22:03:33 UTC) #2
jar (doing other things)
LGTM (nit below might go into different CL). https://codereview.chromium.org/12226121/diff/9002/base/nix/mime_util_xdg.cc File base/nix/mime_util_xdg.cc (right): https://codereview.chromium.org/12226121/diff/9002/base/nix/mime_util_xdg.cc#newcode519 base/nix/mime_util_xdg.cc:519: desktop_env ...
7 years, 10 months ago (2013-02-13 03:15:56 UTC) #3
brettw
7 years, 10 months ago (2013-02-13 20:45:34 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/12226121/diff/9002/base/nix/mime_util_xdg.cc
File base/nix/mime_util_xdg.cc (right):

https://codereview.chromium.org/12226121/diff/9002/base/nix/mime_util_xdg.cc#...
base/nix/mime_util_xdg.cc:519: desktop_env ==
base::nix::DESKTOP_ENVIRONMENT_KDE4) {
I'll fix the extra "base::" and do a new patch. I had to revert this because I
messed up something on Windows.

Powered by Google App Engine
This is Rietveld 408576698