Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
index dd1e2781ee8a36a6d8da6f0d22c6ed28a0467e11..cc061069440b6368821adc09885c3f589c86f0a3 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
@@ -70,7 +70,7 @@ private:
{
}
- virtual ScriptValue call(ScriptValue arg) override
+ ScriptValue call(ScriptValue arg) override
{
m_owner.m_arg = arg;
m_owner.m_callCount++;
@@ -111,9 +111,9 @@ public:
{
}
- virtual ~ExpectDOMException() override { }
+ ~ExpectDOMException() override { }
- virtual void operator()(ScriptValue value) const override
+ void operator()(ScriptValue value) const override
{
DOMException* exception = V8DOMException::toImplWithTypeCheck(value.isolate(), value.v8Value());
EXPECT_TRUE(exception) << "the value should be a DOMException";
@@ -132,9 +132,9 @@ private:
class NotReachedWebServiceWorkerProvider : public WebServiceWorkerProvider {
public:
- virtual ~NotReachedWebServiceWorkerProvider() override { }
+ ~NotReachedWebServiceWorkerProvider() override { }
- virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerRegistrationCallbacks* callbacks) override
+ void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerRegistrationCallbacks* callbacks) override
{
ADD_FAILURE() << "the provider should not be called to register a Service Worker";
delete callbacks;
@@ -278,9 +278,9 @@ private:
{
}
- virtual ~WebServiceWorkerProviderImpl() override { }
+ ~WebServiceWorkerProviderImpl() override { }
- virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerRegistrationCallbacks* callbacks) override
+ void registerServiceWorker(const WebURL& pattern, const WebURL& scriptURL, WebServiceWorkerRegistrationCallbacks* callbacks) override
{
m_owner.m_registerCallCount++;
m_owner.m_registerScope = pattern;
@@ -288,7 +288,7 @@ private:
m_registrationCallbacksToDelete.append(adoptPtr(callbacks));
}
- virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks* callbacks) override
+ void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks* callbacks) override
{
m_owner.m_getRegistrationCallCount++;
m_owner.m_getRegistrationURL = documentURL;
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698