Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
index c4446bc4ab3a66f30c3f209e833ede1217bcb2c8..0e5676b1eeef31f9b82aa08cf2c58d7385c428db 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
@@ -61,9 +61,9 @@ class RegistrationCallback : public WebServiceWorkerProvider::WebServiceWorkerRe
public:
explicit RegistrationCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual ~RegistrationCallback() { }
+ ~RegistrationCallback() override { }
- virtual void onSuccess(WebServiceWorkerRegistration* registration) override
+ void onSuccess(WebServiceWorkerRegistration* registration) override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
return;
@@ -71,7 +71,7 @@ public:
}
// Takes ownership of |errorRaw|.
- virtual void onError(WebServiceWorkerError* errorRaw) override
+ void onError(WebServiceWorkerError* errorRaw) override
{
OwnPtr<WebServiceWorkerError> error = adoptPtr(errorRaw);
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
@@ -88,9 +88,9 @@ class GetRegistrationCallback : public WebServiceWorkerProvider::WebServiceWorke
public:
explicit GetRegistrationCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual ~GetRegistrationCallback() { }
+ ~GetRegistrationCallback() override { }
- virtual void onSuccess(WebServiceWorkerRegistration* registration) override
+ void onSuccess(WebServiceWorkerRegistration* registration) override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
return;
@@ -103,7 +103,7 @@ public:
}
// Takes ownership of |errorRaw|.
- virtual void onError(WebServiceWorkerError* errorRaw) override
+ void onError(WebServiceWorkerError* errorRaw) override
{
OwnPtr<WebServiceWorkerError> error = adoptPtr(errorRaw);
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
@@ -120,10 +120,10 @@ class GetRegistrationsCallback : public WebServiceWorkerProvider::WebServiceWork
public:
explicit GetRegistrationsCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
- virtual ~GetRegistrationsCallback() { }
+ ~GetRegistrationsCallback() override { }
// Takes ownership of |registrationsRaw|.
- virtual void onSuccess(WebVector<WebServiceWorkerRegistration*>* registrationsRaw) override
+ void onSuccess(WebVector<WebServiceWorkerRegistration*>* registrationsRaw) override
{
OwnPtr<WebVector<WebServiceWorkerRegistration*>> registrations = adoptPtr(registrationsRaw);
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
@@ -132,7 +132,7 @@ public:
}
// Takes ownership of |errorRaw|.
- virtual void onError(WebServiceWorkerError* errorRaw) override
+ void onError(WebServiceWorkerError* errorRaw) override
{
OwnPtr<WebServiceWorkerError> error = adoptPtr(errorRaw);
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.h ('k') | Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698