Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 1227783004: Fix virtual/override/final usage in Source/modules/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
index c6d02f93232c4757de277a6b4c6944282c29bdfd..323034eef93ae6dc24064aed3813e758c6664723 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
@@ -59,11 +59,11 @@ class MODULES_EXPORT ServiceWorkerGlobalScope final : public WorkerGlobalScope {
public:
static PassRefPtrWillBeRawPtr<ServiceWorkerGlobalScope> create(ServiceWorkerThread*, PassOwnPtr<WorkerThreadStartupData>);
- virtual ~ServiceWorkerGlobalScope();
- virtual bool isServiceWorkerGlobalScope() const override { return true; }
+ ~ServiceWorkerGlobalScope() override;
+ bool isServiceWorkerGlobalScope() const override { return true; }
// WorkerGlobalScope
- virtual void didEvaluateWorkerScript() override;
+ void didEvaluateWorkerScript() override;
// ServiceWorkerGlobalScope.idl
ServiceWorkerClients* clients();
@@ -79,9 +79,9 @@ public:
void setRegistration(WebServiceWorkerRegistration*);
// EventTarget
- virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;
- virtual const AtomicString& interfaceName() const override;
- virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
+ bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;
+ const AtomicString& interfaceName() const override;
+ bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
void dispatchExtendableEvent(PassRefPtrWillBeRawPtr<Event>, WaitUntilObserver*);

Powered by Google App Engine
This is Rietveld 408576698