Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 1226373006: clang/win: Take another stab at building with -Wunused-private-field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index a428292e196cdb08403245d14ccf94be4b63bc6e..832cc06dcb6b7ab89fea542fbec1975ef952d719 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -51,6 +51,16 @@ static_library("libphonenumber_without_metadata") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ config("libphonenumber_without_metadata_warnings") {
+ if (is_clang) {
+ cflags = [
+ # https://github.com/googlei18n/libphonenumber/pull/741
+ "-Wno-unused-private-field",
+ ]
+ }
+ }
+ configs += [ ":libphonenumber_without_metadata_warnings" ]
+
public_configs = [ ":libphonenumber_config" ]
public_deps = [
« no previous file with comments | « third_party/cld_2/cld_2.gyp ('k') | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698