Issue 1226123014: Align VK with left edge of screen when shelf is left positioned

Issue 1226123014: Align VK with left edge of screen when shelf is left positioned (Closed)

Created:
5 years, 5 months ago by bshe

Modified:
5 years, 5 months ago

Reviewers:
sadrul

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Align VK with left edge of screen when shelf is left positioned BUG=510595 TEST=see crbug.com/510595 Committed: https://crrev.com/16f12e0a2b2723a982ba5faebe4f79203c5e0bf7 Cr-Commit-Position: refs/heads/master@{#339445}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	ui/keyboard/keyboard_controller_unittest.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	ui/keyboard/keyboard_layout_manager.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Total messages: 9 (2 generated)

bshe

On 2015/07/16 21:44:04, bshe wrote: > Hi Sadrul. > > Could you please take a ...

5 years, 5 months ago (2015-07-17 21:46:49 UTC) #3

sadrul

Just to confirm: in this case, the VK shows up above the shelf, right? lgtm

5 years, 5 months ago (2015-07-19 01:29:20 UTC) #4

bshe

On 2015/07/19 01:29:20, sadrul wrote: > Just to confirm: in this case, the VK shows ...

5 years, 5 months ago (2015-07-20 13:15:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226123014/1

5 years, 5 months ago (2015-07-20 13:15:58 UTC) #7

commit-bot: I haz the power

5 years, 5 months ago (2015-07-20 14:08:28 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/16f12e0a2b2723a982ba5faebe4f79203c5e0bf7
Cr-Commit-Position: refs/heads/master@{#339445}