chrome/browser/webdata/web_data_service.cc - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/web_data_service.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable warning, fix some locations, disable for some subprojects Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/webdata/web_data_service.cc

diff --git a/chrome/browser/webdata/web_data_service.cc b/chrome/browser/webdata/web_data_service.cc

index d4f8b71fb3cbc000222c9a84bc172c08eb4431b1..883ad807d5f2d4b7b660d86aba49803641d93ed6 100644

--- a/chrome/browser/webdata/web_data_service.cc

+++ b/chrome/browser/webdata/web_data_service.cc

@@ -331,7 +331,7 @@ void WebDataService::RemoveAutofillProfilesAndCreditCardsModifiedBetween(

WebDataService::~WebDataService() {

if (is_running_ && db_) {

- DLOG_ASSERT("WebDataService dtor called without Shutdown");

+ DLOG_ASSERT(false) << "WebDataService dtor called without Shutdown";

NOTREACHED();

Nico 2013/02/21 20:36:00 NOTREACHED() << "WebDataService dtor called withou

scottmg 2013/02/21 20:47:57 Done.

}