build/common.gypi - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable warning, fix some locations, disable for some subprojects Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 12e9e64448d1c194c849f0274106c0216f13749f..c8f64d0e60293f0d7e7cb0e8145cd9c218a546f8 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2804,6 +2804,9 @@

# Warns on switches on enums that cover all enum values but

# also contain a default: branch. Chrome is full of that.

'-Wno-covered-switch-default',

+ # Warns when a const char[] is converted to bool.

+ '-Wstring-conversion',

'cflags!': [

# Clang doesn't seem to know know this flag.