chrome/browser/renderer_host/web_cache_manager_unittest.cc - Issue 12258039: enable -Wstring-conversion when compiling with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/web_cache_manager_unittest.cc

Issue 12258039: enable -Wstring-conversion when compiling with clang (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enable warning, fix some locations, disable for some subprojects Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/web_cache_manager_unittest.cc

diff --git a/chrome/browser/renderer_host/web_cache_manager_unittest.cc b/chrome/browser/renderer_host/web_cache_manager_unittest.cc

index 4d82178785d6f5a85184a4a0ad3ecca206dd76d7..80f1716e6118c56a5ce77640a6c2ec8487e58560 100644

--- a/chrome/browser/renderer_host/web_cache_manager_unittest.cc

+++ b/chrome/browser/renderer_host/web_cache_manager_unittest.cc

@@ -256,7 +256,7 @@ TEST_F(WebCacheManagerTest, AttemptTacticTest) {

else if (iter->first == kRendererID2)

EXPECT_LE(kStats2.liveSize, iter->second);

else

- EXPECT_FALSE("Unexpected entry in strategy");

+ ADD_FAILURE(); // Unexpected entry in strategy.

++iter;

}

@@ -296,7 +296,7 @@ TEST_F(WebCacheManagerTest, AddToStrategyTest) {

else if (iter->first == kRendererID2)

EXPECT_LE(kStats2.liveSize + kStats2.deadSize, iter->second);

else

- EXPECT_FALSE("Unexpected entry in strategy");

+ ADD_FAILURE(); // Unexpected entry in strategy.

++iter;

}