Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1225763002: Remove debugger id, use local frame id instead. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove debugger id, use local frame id instead. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198395

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M Source/bindings/core/v8/WindowProxy.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.cpp View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 2 chunks +1 line, -10 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
dgozman
Take a look please.
5 years, 5 months ago (2015-07-06 10:47:10 UTC) #2
pfeldman
https://codereview.chromium.org/1225763002/diff/1/Source/bindings/core/v8/WindowProxy.cpp File Source/bindings/core/v8/WindowProxy.cpp (right): https://codereview.chromium.org/1225763002/diff/1/Source/bindings/core/v8/WindowProxy.cpp#newcode258 Source/bindings/core/v8/WindowProxy.cpp:258: MainThreadDebugger::setContextDebugData(context, m_world->worldId() == MainWorldId ? "page" : "injected", frame); ...
5 years, 5 months ago (2015-07-06 12:35:50 UTC) #4
pfeldman
lgtm
5 years, 5 months ago (2015-07-06 12:44:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225763002/40001
5 years, 5 months ago (2015-07-07 11:33:17 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 12:29:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198395

Powered by Google App Engine
This is Rietveld 408576698