Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1217773007: [DevTools] Replace reportCompiledScripts with explicit [get]compiledScripts. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Replace reportCompiledScripts with explicit [get]compiledScripts. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198392

Patch Set 1 #

Total comments: 4

Patch Set 2 : getCompiledScripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptDebugListener.h View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/inspector/V8Debugger.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/V8Debugger.cpp View 1 5 chunks +10 lines, -9 lines 0 comments Download
M Source/core/inspector/WorkerThreadDebugger.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1216863004 Patch 1

Dependent Patchsets:

Issue 1225763002 Patch 40001

Messages

Total messages: 10 (3 generated)
dgozman
Take a look please.
5 years, 5 months ago (2015-07-06 16:42:04 UTC) #2
yurys
https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/MainThreadDebugger.cpp File Source/core/inspector/MainThreadDebugger.cpp (right): https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/MainThreadDebugger.cpp#newcode120 Source/core/inspector/MainThreadDebugger.cpp:120: for (size_t i = 0; i < compiledScripts.size(); i++) ...
5 years, 5 months ago (2015-07-07 06:44:55 UTC) #3
dgozman
https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/MainThreadDebugger.cpp File Source/core/inspector/MainThreadDebugger.cpp (right): https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/MainThreadDebugger.cpp#newcode120 Source/core/inspector/MainThreadDebugger.cpp:120: for (size_t i = 0; i < compiledScripts.size(); i++) ...
5 years, 5 months ago (2015-07-07 07:29:48 UTC) #4
yurys
lgtm modulo renaming compiledScripts->getCompiledScripts
5 years, 5 months ago (2015-07-07 08:05:55 UTC) #5
dgozman
https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/V8Debugger.cpp File Source/core/inspector/V8Debugger.cpp (right): https://codereview.chromium.org/1217773007/diff/1/Source/core/inspector/V8Debugger.cpp#newcode109 Source/core/inspector/V8Debugger.cpp:109: void V8Debugger::compiledScripts(const String& contextDebugDataSubstring, Vector<ScriptDebugListener::ParsedScript>& result) On 2015/07/07 06:44:54, ...
5 years, 5 months ago (2015-07-07 10:07:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217773007/20001
5 years, 5 months ago (2015-07-07 10:07:46 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 11:29:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198392

Powered by Google App Engine
This is Rietveld 408576698