Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224553008: [DevTools] Move Script and enums from ScriptDebugListener to V8Debugger. (Closed)

Created:
5 years, 5 months ago by dgozman
Modified:
5 years, 5 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Move Script and enums from ScriptDebugListener to V8Debugger. ScriptDebugListener itself will be removed in next patch. BUG=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -204 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 5 chunks +23 lines, -23 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptDebugListener.h View 2 chunks +3 lines, -65 lines 0 comments Download
M Source/core/inspector/ScriptDebugListener.cpp View 1 chunk +0 lines, -97 lines 0 comments Download
M Source/core/inspector/V8Debugger.h View 4 chunks +67 lines, -3 lines 1 comment Download
M Source/core/inspector/V8Debugger.cpp View 5 chunks +102 lines, -8 lines 0 comments Download
M Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1225763002 Patch 40001

Dependent Patchsets:

Issue 1214863013 Patch 1

Messages

Total messages: 4 (1 generated)
dgozman
Take a look please.
5 years, 5 months ago (2015-07-07 11:38:24 UTC) #2
pfeldman
lgtm
5 years, 5 months ago (2015-07-07 11:52:32 UTC) #3
yurys
5 years, 5 months ago (2015-07-07 14:13:45 UTC) #4 
https://codereview.chromium.org/1224553008/diff/1/Source/core/inspector/V8Deb...
File Source/core/inspector/V8Debugger.h (right):

https://codereview.chromium.org/1224553008/diff/1/Source/core/inspector/V8Deb...
Source/core/inspector/V8Debugger.h:53: class Script {
As discussed offline I'd rather we moved this class into its own file.

Powered by Google App Engine
This is Rietveld 408576698