Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1225713002: Add a space before period in review URL (Closed)

Created:
5 years, 5 months ago by Sergiy Byelozyorov
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel, smut
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a space before period in review URL This is needed to ensure that it resolves to a correct URL on Gitiles. R=maruel@chromium.org, smut@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295932

Patch Set 1 #

Patch Set 2 : Make sure that the fix also works for Xcode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M git_cl.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Sergiy Byelozyorov
5 years, 5 months ago (2015-07-06 08:56:01 UTC) #2
Sergiy Byelozyorov
Strangely, smut@chromium.org doesn't resolve - changed to smut@google.com. Sana, can you please update https://code.google.com/p/chromium/wiki/UserHandleMapping to ...
5 years, 5 months ago (2015-07-06 08:59:03 UTC) #4
M-A Ruel
lgtm On 2015/07/06 08:59:03, Sergiy Byelozyorov wrote: > Strangely, mailto:smut@chromium.org doesn't resolve - changed to ...
5 years, 5 months ago (2015-07-06 13:48:39 UTC) #5
Sergiy Byelozyorov
On 2015/07/06 13:48:39, M-A Ruel wrote: > lgtm > > > On 2015/07/06 08:59:03, Sergiy ...
5 years, 5 months ago (2015-07-06 14:41:43 UTC) #6
smut
On 2015/07/06 14:41:43, Sergiy Byelozyorov wrote: > On 2015/07/06 13:48:39, M-A Ruel wrote: > > ...
5 years, 5 months ago (2015-07-06 20:07:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225713002/20001
5 years, 5 months ago (2015-07-07 10:31:17 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 10:33:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295932

Powered by Google App Engine
This is Rietveld 408576698