Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: git_cl.py

Issue 1225713002: Add a space before period in review URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Make sure that the fix also works for Xcode Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index f99f5e99a269bcaafa9b1bae48a65941e9fdea5f..bad7c57ac83b666c04e8c59d49add3575fd173d2 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2545,8 +2545,10 @@ def SendUpstream(parser, args, cmd):
commit_desc = ChangeDescription(change_desc.description)
if cl.GetIssue():
# Xcode won't linkify this URL unless there is a non-whitespace character
- # after it. Add a period on a new line to circumvent this.
- commit_desc.append_footer('Review URL: %s.' % cl.GetIssueURL())
+ # after it. Add a period on a new line to circumvent this. Also add a space
+ # before the period to make sure that Gitiles continues to correctly resolve
+ # the URL.
+ commit_desc.append_footer('Review URL: %s .' % cl.GetIssueURL())
if options.contributor:
commit_desc.append_footer('Patch from %s.' % options.contributor)
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698